Skip to content

fix: update secret var alert icon to use danger text color#6562

Merged
bijin-bruno merged 1 commit intousebruno:mainfrom
gopu-bruno:fix/secret-var-alert-icon-danger-color
Dec 30, 2025
Merged

fix: update secret var alert icon to use danger text color#6562
bijin-bruno merged 1 commit intousebruno:mainfrom
gopu-bruno:fix/secret-var-alert-icon-danger-color

Conversation

@gopu-bruno
Copy link
Collaborator

@gopu-bruno gopu-bruno commented Dec 30, 2025

Description

This PR updates the secret variable alert icon color across the application to use theme.colors.text.danger.

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Style
    • Updated styling for sensitive field warning icons by implementing a unified tooltip styling system. This refactoring consolidates icon styling approaches, improves visual consistency across the application, simplifies CSS maintenance, and ensures a more cohesive design for all warning indicators without affecting the current appearance or user experience.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2025

Walkthrough

The SensitiveFieldWarning component's styling is updated to use a new theme-aware tooltip-icon class with danger text color instead of a hardcoded Tailwind color. The icon's styling is extracted into a reusable class definition in StyledWrapper.

Changes

Cohort / File(s) Summary
SensitiveFieldWarning component styling
packages/bruno-app/src/components/SensitiveFieldWarning/StyledWrapper.js, packages/bruno-app/src/components/SensitiveFieldWarning/index.js
Added new .tooltip-icon CSS rule with theme-based danger text color; replaced hardcoded text-amber-600 Tailwind class with the new tooltip-icon class on IconAlertTriangle component.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • PR #6543: Updates component styling to use theme.colors.text.danger for danger-colored elements, aligning with this PR's theming approach.

Suggested reviewers

  • lohit-bruno
  • bijin-bruno
  • helloanoop

Poem

🎨 A warning icon dressed in theme,
No more amber—danger's dream.
Classes bloom where colors flow,
Sensitive fields now brightly glow. ⚠️

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating a secret variable alert icon color to use the theme's danger text color.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bijin-bruno bijin-bruno merged commit 5dad137 into usebruno:main Dec 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants