packages/bruno-electron/src/ipc/collection.js (1)

854-863: Consider extracting getFilenameWithFormat to module scope for reuse.

The helper is currently scoped to the importCollection handler. Similar logic exists in the clone-folder handler (lines 978-979), suggesting this utility could be reused across multiple IPC handlers.

🔎 Proposed refactor to extract helper to module scope

Move the helper function to module scope (e.g., after line 72, near other utility functions):

 const uiStateSnapshotStore = new UiStateSnapshotStore();
+
+const getFilenameWithFormat = (item, format) => {
+  if (item?.filename) {
+    const ext = path.extname(item.filename);
+    if (ext === '.bru' || ext === '.yml') {
+      return item.filename.replace(ext, `.${format}`);
+    }
+    return item.filename;
+  }
+  return `${item.name}.${format}`;
+};

 // size and file count limits to determine whether the bru files in the collection should be loaded asynchronously or not.

Then update the clone-folder handler to use it:

         if (['http-request', 'graphql-request', 'grpc-request'].includes(item.type)) {
           const content = await stringifyRequestViaWorker(item, { format });

-          // Use the correct file extension based on target format
-          const baseName = path.parse(item.filename).name;
-          const newFilename = format === 'yml' ? `${baseName}.yml` : `${baseName}.bru`;
+          const newFilename = getFilenameWithFormat(item, format);
           const filePath = path.join(currentPath, newFilename);

packages/bruno-app/src/components/Sidebar/ImportCollectionLocation/index.js (1)

214-237: Review help text accuracy and label consistency.

The format selection UI is functionally correct, but consider the following refinements:

1. Line 220: The help text claims "Industry-standard YAML format" for OpenCollection. Verify this is accurate, as OpenCollection appears to be a Bruno-specific format rather than a widely adopted industry standard.

2. Lines 234-235: The option labels use inconsistent patterns:

   • "OpenCollection (YAML)"
   • "BRU Format (.bru)"

   Consider standardizing to either include or exclude file extensions in both labels, e.g.:

   • "OpenCollection (.yml)" and "BRU (.bru)", or
   • "OpenCollection (YAML)" and "BRU"

🔎 Proposed refinement for clarity

               <Help width="300">
                 <p>Choose the file format for storing requests in this collection.</p>
                 <p className="mt-2">
-                  <strong>OpenCollection (YAML):</strong> Industry-standard YAML format (.yml files)
+                  <strong>OpenCollection (YAML):</strong> YAML-based format (.yml files)
                 </p>
                 <p className="mt-1">
                   <strong>BRU:</strong> Bruno's native file format (.bru files)
                 </p>
               </Help>
             </label>
             <select
               id="format"
               name="format"
               className="block textbox mt-2 w-full"
               value={collectionFormat}
               onChange={(e) => setCollectionFormat(e.target.value)}
             >
-              <option value="yml">OpenCollection (YAML)</option>
-              <option value="bru">BRU Format (.bru)</option>
+              <option value="yml">OpenCollection (.yml)</option>
+              <option value="bru">BRU (.bru)</option>
             </select>

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: naman-bruno
Repo: usebruno/bruno PR: 6407
File: packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js:5-41
Timestamp: 2025-12-17T21:41:24.730Z
Learning: Do not suggest PropTypes validation for React components in the Bruno codebase. The project does not use PropTypes, so reviews should avoid proposing PropTypes and rely on the existing typing/validation approach (e.g., TypeScript or alternative runtime checks) if applicable. This guideline applies broadly to all JavaScript/JSX components in the repo.

Learnt from: sanish-bruno
Repo: usebruno/bruno PR: 6090
File: tests/scripting/hooks/init-user-data/ui-state-snapshot.json:1-8
Timestamp: 2025-12-16T07:16:23.647Z
Learning: For e2e tests in the bruno repository: Collections that are shared between CLI and UI tests (comprehensive test suites testing core functionality) should be placed in `packages/bruno-tests/` to avoid duplication. The `tests/**/fixtures/collection` pattern should be used for test-specific collections that test particular UI behaviors or are specific to a single test file.