Skip to content

fix: update selectedTab prop to use selectedViewTab#6478

Merged
bijin-bruno merged 1 commit intousebruno:mainfrom
abhishek-bruno:fix/response-type-persistance-bugfix
Dec 22, 2025
Merged

fix: update selectedTab prop to use selectedViewTab#6478
bijin-bruno merged 1 commit intousebruno:mainfrom
abhishek-bruno:fix/response-type-persistance-bugfix

Conversation

@abhishek-bruno
Copy link
Member

@abhishek-bruno abhishek-bruno commented Dec 22, 2025 •
edited by coderabbitai bot
Loading

Description

fix: update selectedTab prop to use selectedViewTab in ResponsePane component

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Refactor
    • Internal state management optimization in the response view component. No changes to user-facing functionality or behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025 •
edited
Loading

Walkthrough

The pull request updates ResponsePane to pass selectedViewTab instead of selectedTab to the QueryResult and ResponsePaneActions components, changing which internal tab state is consumed by these child components.

Changes

Cohort / File(s) Summary
Tab state prop substitution
packages/bruno-app/src/components/ResponsePane/index.js		 Changed selectedTab to selectedViewTab prop passed to QueryResult and ResponsePaneActions components

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify that selectedViewTab is the intended state variable for these components
  • Confirm that related PRs #6436 and #6475 are part of a coordinated refactoring

Possibly related PRs

Suggested reviewers

  • helloanoop
  • lohit-bruno
  • naman-bruno
  • bijin-bruno

Poem

🎯 A tab state's gentle migration,
From old to new designation,
selectedViewTab takes the stage,
Writing a cleaner page,
The ResponsePane's navigation shines bright! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the selectedTab prop to use selectedViewTab in the ResponsePane component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 669c99f and 5d302c3.

📒 Files selected for processing (1)
  • packages/bruno-app/src/components/ResponsePane/index.js
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (CODING_STANDARDS.md)

**/*.{js,jsx,ts,tsx}: Use 2 spaces for indentation. No tabs, just spaces
Stick to single quotes for strings. For JSX/TSX attributes, use double quotes (e.g., )
Always add semicolons at the end of statements
No trailing commas
Always use parentheses around parameters in arrow functions, even for single params
For multiline constructs, put opening braces on the same line, and ensure consistency. Minimum 2 elements for multiline
No newlines inside function parentheses
Space before and after the arrow in arrow functions. () => {} is good
No space between function name and parentheses. func() not func ()
Semicolons go at the end of the line, not on a new line
Names for functions need to be concise and descriptive
Add in JSDoc comments to add more details to the abstractions if needed
Add in meaningful comments instead of obvious ones where complex code flow is explained properly

Files:

  • packages/bruno-app/src/components/ResponsePane/index.js
🧠 Learnings (1)
📚 Learning: 2025-12-17T21:41:24.730Z 
Learnt from: naman-bruno
Repo: usebruno/bruno PR: 6407
File: packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js:5-41
Timestamp: 2025-12-17T21:41:24.730Z
Learning: Do not suggest PropTypes validation for React components in the Bruno codebase. The project does not use PropTypes, so reviews should avoid proposing PropTypes and rely on the existing typing/validation approach (e.g., TypeScript or alternative runtime checks) if applicable. This guideline applies broadly to all JavaScript/JSX components in the repo.

Applied to files:

  • packages/bruno-app/src/components/ResponsePane/index.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: SSL Tests - Linux
  • GitHub Check: SSL Tests - macOS
  • GitHub Check: SSL Tests - Windows
  • GitHub Check: Unit Tests
  • GitHub Check: Playwright E2E Tests
  • GitHub Check: CLI Tests
🔇 Additional comments (2)
packages/bruno-app/src/components/ResponsePane/index.js (2)

257-257: ResponsePaneActions correctly accepts and uses the selectedTab prop.

The component destructures selectedTab from props and properly forwards it to the ResponseCopy component for view tab state management.

162-162: The selectedTab prop is correctly passed to both QueryResult and ResponsePaneActions components.

Both child components properly accept the selectedTab parameter (documenting it as 'editor' or 'preview') and use it appropriately. QueryResult uses the prop in the queryFilterEnabled useMemo condition on line 169, and both components pass it to their respective children. The changes correctly propagate the persisted view tab state through the component tree to maintain user preference across requests.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bijin-bruno bijin-bruno merged commit cba164b into usebruno:main Dec 22, 2025
8 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jan 12, 2026
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bijin-bruno bijin-bruno bijin-bruno approved these changes

@helloanoop helloanoop Awaiting requested review from helloanoop helloanoop is a code owner

@lohit-bruno lohit-bruno Awaiting requested review from lohit-bruno lohit-bruno is a code owner

@naman-bruno naman-bruno Awaiting requested review from naman-bruno naman-bruno is a code owner

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abhishek-bruno @bijin-bruno