Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughA large-scale theming and styling refactor across the Bruno app. Updates include consolidating workspace.accent references to theme.brand, standardizing typography using theme tokens instead of hardcoded values, adjusting UI spacing and padding for visual consistency, and updating theme color definitions for HTTP methods and accent colors. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~35 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (18)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements design refinements across the Bruno app, focusing on color palette consistency, typography standardization, and spacing improvements. The changes migrate from workspace.accent to a unified theme.brand and theme.colors.accent system, update HTTP method colors to be more harmonious with the overall design system, and normalize spacing patterns.
Key Changes
- Unified color system by adding
colors.accentto both themes and migrating UI components fromworkspace.accenttotheme.brandortheme.colors.accent - Refined HTTP method and protocol colors (GET, POST, PUT, DELETE, gRPC, WebSocket, GraphQL) to be more cohesive with the design system
- Standardized spacing (margin bottom from 1px to 3px) and typography (font-weight from 600 to 500, font-size to theme variables) across multiple components
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/bruno-app/src/themes/light.js | Adds colors.accent and updates HTTP method/protocol colors with design-aligned palette |
| packages/bruno-app/src/themes/dark.js | Adds colors.accent and updates HTTP method/protocol colors with design-aligned palette |
| packages/bruno-app/src/components/WorkspaceHome/WorkspaceOverview/StyledWrapper.js | Migrates from workspace.accent to theme.brand for buttons, removes hardcoded font-weight |
| packages/bruno-app/src/components/WorkspaceHome/WorkspaceEnvironments/EnvironmentList/StyledWrapper.js | Standardizes title typography to use theme variables (font-size, font-weight) |
| packages/bruno-app/src/components/WorkspaceHome/WorkspaceEnvironments/EnvironmentList/EnvironmentDetails/StyledWrapper.js | Standardizes title typography to use theme variables |
| packages/bruno-app/src/components/WorkspaceHome/WorkspaceEnvironments/EnvironmentList/EnvironmentDetails/EnvironmentVariables/StyledWrapper.js | Migrates colors to new system, standardizes spacing and typography, removes hardcoded font-sizes |
| packages/bruno-app/src/components/WorkspaceHome/WorkspaceDocs/StyledWrapper.js | Migrates button styling from workspace.accent to theme.brand |
| packages/bruno-app/src/components/ResponseExample/ResponseExampleRequestPane/ResponseExampleParams/index.js | Increases title spacing from mb-1 to mb-3 for consistency |
| packages/bruno-app/src/components/ResponseExample/ResponseExampleRequestPane/ResponseExampleHeaders/index.js | Increases title spacing from mb-1 to mb-3 for consistency |
| packages/bruno-app/src/components/RequestPane/Vars/index.js | Increases title spacing from mb-1 to mb-3 for consistency |
| packages/bruno-app/src/components/RequestPane/QueryParams/index.js | Increases title spacing from mb-1 to mb-3 and mb-2 to mb-3 for consistency |
| packages/bruno-app/src/components/ManageWorkspace/StyledWrapper.js | Migrates button colors from workspace.accent to theme.brand |
| packages/bruno-app/src/components/FolderSettings/Vars/index.js | Increases title spacing from mb-1/mt-1 to mb-3/mt-3 for consistency |
| packages/bruno-app/src/components/Environments/EnvironmentSettings/EnvironmentList/StyledWrapper.js | Standardizes title typography to use theme variables |
| packages/bruno-app/src/components/Environments/EnvironmentSettings/EnvironmentList/EnvironmentDetails/StyledWrapper.js | Standardizes typography to use theme variables and reduces font-weight |
| packages/bruno-app/src/components/Environments/EnvironmentSettings/EnvironmentList/EnvironmentDetails/EnvironmentVariables/StyledWrapper.js | Migrates colors to new system, standardizes spacing and typography, removes hardcoded font-sizes |
| packages/bruno-app/src/components/EditableTable/StyledWrapper.js | Migrates to table.thead.color, adds explicit font-weight, standardizes padding, removes hardcoded font-sizes |
| packages/bruno-app/src/components/CollectionSettings/Vars/index.js | Increases title spacing from mb-1/mt-1 to mb-3/mt-3 for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
163
to
170
| .reset { | ||
| background: transparent; | ||
| padding: 6px 16px; | ||
| border: 1px solid ${(props) => props.theme.workspace.accent}; | ||
| color: ${(props) => props.theme.workspace.accent}; | ||
| color: ${(props) => props.theme.brand}; | ||
| &:hover { | ||
| opacity: 0.9; | ||
| } | ||
| } |
There was a problem hiding this comment.
The .reset button is missing a border property. Before this change, it had a border. Now it will inherit border: none from the generic button selector at line 134, which may result in an invisible or less prominent button. Consider adding border: none; explicitly if this is intentional, or restore the border if this was an accidental deletion.
Comment on lines
162
to
169
| .reset { | ||
| background: transparent; | ||
| padding: 6px 16px; | ||
| border: 1px solid ${(props) => props.theme.workspace.accent}; | ||
| color: ${(props) => props.theme.workspace.accent}; | ||
| color: ${(props) => props.theme.brand}; | ||
| &:hover { | ||
| opacity: 0.9; | ||
| } | ||
| } |
There was a problem hiding this comment.
The .reset button is missing a border property. Before this change, it had a border. Now it will inherit border: none from the generic button selector at line 133, which may result in an invisible or less prominent button. Consider adding border: none; explicitly if this is intentional, or restore the border if this was an accidental deletion.
This was referenced Dec 18, 2025
Merged
This was referenced Dec 29, 2025
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design Tweaks
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.