feat: opencollection actions by helloanoop · Pull Request #6460 · usebruno/bruno

helloanoop · 2025-12-18T15:50:51Z

Description

Opencollection Actions

Summary by CodeRabbit

New Features
- Added support for post-response variables in HTTP and GraphQL requests.
Chores
- Updated @opencollection/types dependency to version 0.3.0.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-18T15:51:02Z

Caution

Review failed

The pull request is closed.

Walkthrough

This PR adds bidirectional conversion between Bruno post-response variables and OpenCollection actions. It introduces mapping helpers in actions.ts, updates request parsers to extract post-response variables from runtime actions, and modifies stringifiers to serialize post-response variables back to runtime actions. Dependency version is upgraded and TypeScript path mappings are adjusted.

Changes

Cohort / File(s)	Summary
Dependency upgrades `package.json`, `packages/bruno-filestore/package.json`	Version bump for `@opencollection/types`: removed `0.2.0`, added `0.3.0` as devDependency in root package.json
Post-response variable converters `packages/bruno-filestore/src/formats/yml/common/actions.ts`	Added `toOpenCollectionActions()` and `toBrunoPostResponseVariables()` helper functions for bidirectional mapping between Bruno post-response variables and OpenCollection actions
Variable handling refactor `packages/bruno-filestore/src/formats/yml/common/variables.ts`	Simplified `toOpenCollectionVariables()` to process only req variables; removed post-response logic from `toBrunoVariables()`
Request parsers `packages/bruno-filestore/src/formats/yml/items/parseGraphQLRequest.ts`, `parseHttpRequest.ts`	Added post-response variable extraction from runtime actions; structured `brunoRequest.vars` as `{ req, res }` composite object
Request stringifiers `packages/bruno-filestore/src/formats/yml/items/stringifyGraphQLRequest.ts`, `stringifyHttpRequest.ts`	Added runtime actions serialization from post-response variables using `toOpenCollectionActions()`
TypeScript configuration `packages/bruno-filestore/tsconfig.json`	Updated `@opencollection/types` path mappings to reference top-level node_modules instead of nested package-specific resolution

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–25 minutes

Areas requiring extra attention:
- Verify bidirectional mapping correctness in actions.ts (null/undefined handling and field mappings)
- Confirm post-response variable handling consistency across all parser/stringifier pairs
- Validate type safety for action filtering by phase and type
- Check that composite vars structure ({ req, res }) is handled correctly throughout the codebase

Possibly related PRs

Revert: Re-add post response vars #6307: Adds post-response variable propagation across runtime, CLI/electron flows, and UI components—directly aligns with this PR's post-response handling expansion
remove: presets and response var #6195: Removes post-response variable handling across the app—represents the inverse of this PR's bidirectional mapping reintroduction

Suggested reviewers

lohit-bruno
naman-bruno
bijin-bruno

Poem

🔄 Variables dance in both directions now,
From post-response to actions, and back—
Bruno and OpenCollection bow,
Their schemas sync without a crack.
✨

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/opencollection-action

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a1c4113 and 9738a2a.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (9)

package.json (1 hunks)
packages/bruno-filestore/package.json (1 hunks)
packages/bruno-filestore/src/formats/yml/common/actions.ts (1 hunks)
packages/bruno-filestore/src/formats/yml/common/variables.ts (3 hunks)
packages/bruno-filestore/src/formats/yml/items/parseGraphQLRequest.ts (2 hunks)
packages/bruno-filestore/src/formats/yml/items/parseHttpRequest.ts (2 hunks)
packages/bruno-filestore/src/formats/yml/items/stringifyGraphQLRequest.ts (2 hunks)
packages/bruno-filestore/src/formats/yml/items/stringifyHttpRequest.ts (2 hunks)
packages/bruno-filestore/tsconfig.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR introduces OpenCollection actions support by refactoring how post-response variables are handled. Bruno's post-response variables are now converted to OpenCollection 'set-variable' actions with phase 'after-response', providing a more structured approach to handling response-based variable assignments. The dependency on @opencollection/types has been upgraded from 0.2.0 to 0.3.0 and centralized to the root package.

Introduced new actions.ts module with bidirectional conversion functions between Bruno post-response variables and OpenCollection actions
Refactored variables.ts to handle only pre-request variables, removing post-response variable logic
Updated HTTP and GraphQL request stringify/parse functions to use the new actions conversion

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/bruno-filestore/tsconfig.json	Updated TypeScript path mappings to reference @opencollection/types from root node_modules instead of package-specific location
packages/bruno-filestore/src/formats/yml/items/stringifyHttpRequest.ts	Added actions conversion from Bruno post-response variables using toOpenCollectionActions
packages/bruno-filestore/src/formats/yml/items/stringifyGraphQLRequest.ts	Added actions conversion from Bruno post-response variables using toOpenCollectionActions
packages/bruno-filestore/src/formats/yml/items/parseHttpRequest.ts	Updated to convert OpenCollection actions back to Bruno post-response variables using toBrunoPostResponseVariables
packages/bruno-filestore/src/formats/yml/items/parseGraphQLRequest.ts	Updated to convert OpenCollection actions back to Bruno post-response variables using toBrunoPostResponseVariables
packages/bruno-filestore/src/formats/yml/common/variables.ts	Refactored to handle only pre-request variables, removed post-response variable scope marker logic
packages/bruno-filestore/src/formats/yml/common/actions.ts	New module providing bidirectional conversion between Bruno post-response variables and OpenCollection set-variable actions
packages/bruno-filestore/package.json	Removed @opencollection/types from devDependencies (now managed at root level)
package.json	Added @opencollection/types 0.3.0 to root devDependencies
package-lock.json	Updated lock file to reflect dependency changes - removed package-specific @opencollection/types 0.2.0 and added root-level 0.3.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-18T15:54:12Z

packages/bruno-filestore/src/formats/yml/common/actions.ts

+        name: setVarAction.variable?.name || '',
+        value: setVarAction.selector?.expression || '',
+        enabled: setVarAction.disabled !== true,
+        local: false


The local field is hardcoded to false, which causes loss of scope information during round-trip conversion. When an action has scope 'request', it should be converted to a Bruno variable with local: true, but currently all variables are set to local: false. This should be: local: setVarAction.variable?.scope === 'request'

Suggested change

local: false

local: setVarAction.variable?.scope === 'request'

feat: opencollection actions

9738a2a

Copilot AI review requested due to automatic review settings December 18, 2025 15:50

helloanoop requested review from bijin-bruno, lohit-bruno and naman-bruno as code owners December 18, 2025 15:50

pull-request-size bot added the size/L label Dec 18, 2025

Copilot started reviewing on behalf of helloanoop December 18, 2025 15:51 View session

helloanoop merged commit c5827df into main Dec 18, 2025
11 of 12 checks passed

Copilot AI reviewed Dec 18, 2025

View reviewed changes

coderabbitai bot mentioned this pull request Dec 24, 2025

export & import in opencollection format #6329

Merged

6 tasks

coderabbitai bot mentioned this pull request Feb 2, 2026

fix: YML parsing and stringification to support post-response variables #7009

Merged

6 tasks

coderabbitai bot mentioned this pull request Mar 7, 2026

@usebruno/cli npm release with OpenCollection support (PR #7028) #7399

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: opencollection actions#6460

feat: opencollection actions#6460
helloanoop merged 1 commit intomainfrom
feat/opencollection-action

helloanoop commented Dec 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 18, 2025 •

edited

Loading

Review failed

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	local: false
	local: setVarAction.variable?.scope === 'request'

Conversation

helloanoop commented Dec 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

helloanoop commented Dec 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 18, 2025 •

edited

Loading