fix: include request URL in prompt variable extraction#6412
fix: include request URL in prompt variable extraction#6412bijin-bruno merged 1 commit intousebruno:mainfrom
Conversation
WalkthroughThis PR fixes a bug where prompt variables embedded in the request URL (path and port) were not being extracted as prompt variables. The fix adds URL-based variable extraction logic to the Redux action handler, with corresponding test updates to verify the behavior. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used📓 Path-based instructions (2)**/*.{js,jsx,ts,tsx}📄 CodeRabbit inference engine (CODING_STANDARDS.md)
Files:
tests/**/**.*⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (3)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bijin-bruno
left a comment
There was a problem hiding this comment.
Please also update the existing e2e to include a prompt variable in the url.
|
|
||
| const prompts = extractPromptVariables(requestObj); | ||
| prompts.push(...extractPromptVariables(allVariables)); | ||
| prompts.push(...extractPromptVariables(request.url)); |
There was a problem hiding this comment.
Looks like we don't need it here. requestObj should already have url included.
Same applies for electron
c11d006 to
d612889
Compare
fixes: #6405
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Contribution Checklist:
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.