refactor: update runner tests to use new filter implementation and reusable helpers#6085
Merged
sid-bruno merged 14 commits intousebruno:feature/collection-test-results-and-filtering-internalfrom Nov 13, 2025
Conversation
Added breakdown of test results within collection. Added filtering based on passing/failing requests and tests by click on results text.
- Add unified filter bar (All/Passed/Failed/Skipped) with counts and active indicator - Implement filtering that filters both requests and tests within requests - Move action buttons to top bar, prevent filter wrapping - Add close button and placeholder to response view - Update styling for light/dark modes with proper colors and typography
…ring logic - Restore original function formatting with return statements and braces - Restore removed input attributes (autoCorrect, autoCapitalize, spellCheck) - Revert ternary operator changes to match original code style - Restore original variable names (savedConfiguration) and comments - Restore original test results rendering structure - Preserve new filter bar UI, filtering logic, and response view improvements
- Only auto-scroll when user is near the bottom (within 100px) - Preserve user's scroll position if they've scrolled up to view content - Move ref to actual scrollable container for proper scroll detection
…b.com:chirag-bruno/bruno into feature/collection-test-results-and-filtering
… into feature/collection-test-results-and-filtering
…usable helpers - Update tests to read test result counts from filter buttons instead of deprecated 'Total Requests' text - Create reusable helper functions in tests/utils/page/runner.ts: * getRunnerResultCounts() - reads counts from filter button badges * runCollection() - handles collection running with reset logic * setSandboxMode() - sets up developer/safe mode with badge handling * validateRunnerResults() - validates test results against expected counts - Refactor 9 test files to use helper functions: * tests/runner/collection-run.ts * tests/scripting/inbuilt-libraries/jsonwebtoken/jsonwebtoken.spec.ts * All 7 SSL test files (basic-ssl and custom-ca-certs) - Reduce code duplication: ~50 lines per test → ~10 lines per test - Improve maintainability: centralized logic for common test operations - Fix test execution: changed serial tests to parallel where appropriate to prevent skipped tests - Handle security settings tab opening: click badge to open tab when mode already selected This refactoring accommodates the new filter implementation in the runner results UI and significantly improves test code maintainability.
sid-bruno
reviewed
Nov 13, 2025
Collaborator
|
Switching base to |
6049530
into
usebruno:feature/collection-test-results-and-filtering-internal
6 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update tests to read test result counts from filter buttons instead of deprecated 'Total Requests' text
Create reusable helper functions in tests/utils/page/runner.ts:
* getRunnerResultCounts() - reads counts from filter button badges
* runCollection() - handles collection running with reset logic
* setSandboxMode() - sets up developer/safe mode with badge handling
* validateRunnerResults() - validates test results against expected counts
Refactor 9 test files to use helper functions:
This refactoring accommodates the new filter implementation in the runner results UI
and significantly improves test code maintainability.
Contribution Checklist: