test: Add test for restoring duplicate hashes in patternHasher#6071
Merged
bijin-bruno merged 2 commits intousebruno:mainfrom Nov 12, 2025
Merged
test: Add test for restoring duplicate hashes in patternHasher#6071bijin-bruno merged 2 commits intousebruno:mainfrom
bijin-bruno merged 2 commits intousebruno:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the patternHasher function where duplicate template variables were not being properly restored. The fix changes the restore logic from using simple string replacement to using a global regex replacement to ensure all occurrences of each hash are replaced.
- Changed the
restorefunction to useRegExpwith global flag instead of simplereplace - Added a test case to verify that duplicate hashes (e.g., multiple instances of
{{name}}) are correctly restored
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/bruno-common/src/utils/template-hasher.ts | Fixed the restore function to replace all occurrences of each hash using a global regex instead of replacing only the first occurrence |
| packages/bruno-common/src/utils/template-hasher.spec.ts | Added test case to verify that duplicate template variables are correctly restored |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bijin-bruno
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for duplicate names not being replaced
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.