Improve "Close All Collections" community PR#5994
Merged
bijin-bruno merged 3 commits intousebruno:mainfrom Nov 19, 2025
Merged
Conversation
3221e86 to
8d76bf3
Compare
7cee4a4 to
973cc8e
Compare
sanish-bruno
suggested changes
Nov 10, 2025
tests/collection/close-all-collections/close-all-collections.spec.ts
Outdated
Show resolved
Hide resolved
tests/collection/close-all-collections/close-all-collections.spec.ts
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollectionsModal/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollections/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/CollectionsBadge/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollections/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollectionsModal/index.js
Outdated
Show resolved
Hide resolved
bijin-bruno
requested changes
Nov 11, 2025
Collaborator
bijin-bruno
left a comment
There was a problem hiding this comment.
- Please fix the e2e and lint errors - https://github.com/usebruno/bruno/actions/runs/19234269484/job/54979964945?pr=5994
- Please add couple more e2e tests for discard and save actions on close confirmation modal
packages/bruno-app/src/components/Icons/IconCloseCollections/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollections/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollections/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollections/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollections/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollections/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollections/index.js
Outdated
Show resolved
Hide resolved
tests/collection/close-all-collections/close-all-collections.spec.ts
Outdated
Show resolved
Hide resolved
tests/collection/close-all-collections/close-all-collections.spec.ts
Outdated
Show resolved
Hide resolved
tests/collection/close-all-collections/close-all-collections.spec.ts
Outdated
Show resolved
Hide resolved
61f9ea5 to
e6fb648
Compare
bijin-bruno
requested changes
Nov 18, 2025
packages/bruno-app/src/components/Sidebar/Collections/CollectionsHeader/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollectionsModal/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollectionsModal/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollectionsModal/index.js
Outdated
Show resolved
Hide resolved
7f8c50d to
96fe171
Compare
bijin-bruno
requested changes
Nov 18, 2025
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollectionsModal/index.js
Outdated
Show resolved
Hide resolved
tests/collection/close-all-collections/close-all-collections.spec.ts
Outdated
Show resolved
Hide resolved
tests/collection/close-all-collections/init-user-data/preferences.json
Outdated
Show resolved
Hide resolved
168c72d to
3d860bc
Compare
bijin-bruno
requested changes
Nov 19, 2025
packages/bruno-app/src/components/Sidebar/Collections/RemoveCollectionsModal/index.js
Outdated
Show resolved
Hide resolved
bijin-bruno
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BRU-1911
PR - #5662
Screen.Recording.2025-11-10.at.1.27.30.PM.mov