feat: encapsulate tab boundaries into a hook for managing pane dimensions#5878
Merged
sid-bruno merged 6 commits intousebruno:mainfrom Nov 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a custom hook useTabPaneBoundaries to centralize the management of request and response pane dimensions (width and height) across tabs, replacing scattered dimension management logic in the RequestTabPanel component.
Key Changes:
- Added a new
updateRequestPaneTabHeightRedux action to complement the existing width update action - Created
useTabPaneBoundarieshook that encapsulates dimension state and setters for tab panes - Refactored RequestTabPanel to use the new hook, removing local state management and cleanup logic
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/bruno-app/src/providers/ReduxStore/slices/tabs.js | Added updateRequestPaneTabHeight action to store request pane height in tab state |
| packages/bruno-app/src/hooks/useTabPaneBoundaries/index.js | New hook providing unified interface for reading/writing pane boundaries with reset functionality |
| packages/bruno-app/src/components/RequestTabPanel/index.js | Refactored to use the new hook, removing duplicate logic and local state for pane dimensions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a hook to abstract the setting and reading of the pane boundaries (tab request / response pane width / height
Fixes: #5665
JIRA
Screen.Recording.2025-10-24.at.2.09.28.PM.mov
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.