Skip to content

feat: support newlines in headers, params, and variables#5795

Merged
sid-bruno merged 25 commits intousebruno:mainfrom
pooja-bruno:feat-support-newlines-in-headers-params-variables
Nov 17, 2025
Merged

feat: support newlines in headers, params, and variables#5795
sid-bruno merged 25 commits intousebruno:mainfrom
pooja-bruno:feat-support-newlines-in-headers-params-variables

Conversation

@pooja-bruno
Copy link
Collaborator

@pooja-bruno pooja-bruno commented Oct 15, 2025

Description

This PR adds support for newlines in header names, query parameter names, and variable names in Bruno's .bru file format.

JIRA

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.
image

@sid-bruno
Copy link
Collaborator

can we also add in tests for bruToJson and jsonToBru for the multiline checks to keep things reliable

@pooja-bruno pooja-bruno force-pushed the feat-support-newlines-in-headers-params-variables branch from 3e408f6 to ed56417 Compare October 16, 2025 14:19
@pooja-bruno pooja-bruno marked this pull request as draft November 7, 2025 07:32
@pooja-bruno pooja-bruno marked this pull request as ready for review November 10, 2025 06:27
sid-bruno
sid-bruno previously approved these changes Nov 12, 2025
Copy link
Collaborator

@sid-bruno sid-bruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making additional JIRA to add support for response examples https://usebruno.atlassian.net/browse/BRU-2176

@pooja-bruno pooja-bruno force-pushed the feat-support-newlines-in-headers-params-variables branch from 857c8b7 to 7b8b067 Compare November 12, 2025 07:30
esc_quote_char = esc_char quote_char
quoted_key_char = ~(quote_char | esc_quote_char | nl) any
quoted_key = disable_char? quote_char (esc_quote_char | quoted_key_char)* quote_char
multiline_key = disable_char? multilinetextblock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sid-bruno @pooja-bruno @bijin-bruno

We cannot and should not support multiline keys. Yaml does not support it and this will be a blocker for people to migrate over to yaml. Lets discus this in person tomorrow.

Copy link
Collaborator

@sid-bruno sid-bruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants