LGTM

For future as we can get more bandwidth, we can look into just using the source proto files from grpc and creating our own reflection client instead of having to wait for one of the above to add in support for something like v2

Reference Links:
Reflection Protobuf: https://github.com/grpc/grpc/tree/master/src/proto/grpc/reflection
Inference to TS: https://github.com/stephenh/ts-proto
Reference Implementation: https://github.com/deeplay-io/nice-grpc/blob/master/packages/nice-grpc-web/src/service-definitions/index.ts

Hi, as gRPC is still a beta feature, I think this PR can be merged to start getting feedbacks from user

Tried the PR but I have a 16 UNAUTHENTICATED: Missing Authorization header error in the logs, despites giving the auth token.

[1] gRPC reflection v1 failed: ReflectionRequestException [Error]: Error: 16 UNAUTHENTICATED: Missing Authorization header

Moreover, Bruno displays the error as an 2 UNKNOWN error:

Tried the PR but I have a 16 UNAUTHENTICATED: Missing Authorization header error in the logs, despites giving the auth token.

[1] gRPC reflection v1 failed: ReflectionRequestException [Error]: Error: 16 UNAUTHENTICATED: Missing Authorization header

Moreover, Bruno displays the error as an 2 UNKNOWN error:

Thanks for reporting this, This helped a lot in-terms preventing a possible regression ❤️

@reggermont will you able to test whether the authentication error is fixed or after the latest update?

Hi, thanks for the feedback, really appreciate

I still have an 16 UNAUTHENTICATED error, but this time an Invalid credentials

gRPC reflection v1 failed: ReflectionRequestException [Error]: Error: 16 UNAUTHENTICATED: Invalid credentials
Error in gRPC reflection: ReflectionRequestException [Error]: Error: UNAUTHENTICATED: Invalid credentials
Error loading gRPC methods from reflection: ReflectionRequestException [Error]: Error: 16 UNAUTHENTICATED: Invalid credentials

Tried auths: Inherit and Bearer with the token, same error

Still displays as a 2 UNKNOWN in GUI (see my previous message)

Reflection now works 🥳 🎊

Trigerring a call now returns an 13 INTERNAL error: "authorization" metadata cannot have multiple values

Thanks for the steps forward, this is really good news!

@reggermont i have pushed few changes, will you be able to check if that fixes the issue. The fix is for the issue reported eariler, where auth header is missing! any insecure connections was missing header related information. That should be fixed with the latest code.
Let me know if you see Triggering a call now returns an 13 INTERNAL error: "authorization" metadata cannot have multiple values this error with the latest code, will look into it!

Hi Sanish,

I now have the "authorization" metadata cannot have multiple values error on the reflection request

[1] Error loading gRPC methods from reflection: ReflectionRequestException [Error]: Error: 13 INTERNAL: "authorization" metadata cannot have multiple values

This can be because of the combineChannelCredentials which doesn't merge the metadatas. If you pass the authorization header in the channelCredentials and callCredentials, it results on the error

@reggermont I have pushed the changes, removed the logic of attaching metadata to credentials, now it is part of call options. can you please confirm whether this is working for you?

Hi Sanish,

I now have the "authorization" metadata cannot have multiple values error on the reflection request

[1] Error loading gRPC methods from reflection: ReflectionRequestException [Error]: Error: 13 INTERNAL: "authorization" metadata cannot have multiple values

This can be because of the combineChannelCredentials which doesn't merge the metadatas. If you pass the authorization header in the channelCredentials and callCredentials, it results on the error

@reggermont any updates you may want to share, on the latest code?

Hi Sanish, everything's working great on my side. What I have tested:

• Reflection
• Request with a payload and a multi-step response
• Inherit auth

Thanks a lot for the work, hope it can be merged soon

@reggermont 🙏 Thanks, It will be part of next release