Simpler top-level context detection for fish completions#2121
Merged
dearchap merged 2 commits intourfave:mainfrom Apr 29, 2025
Merged
Simpler top-level context detection for fish completions#2121dearchap merged 2 commits intourfave:mainfrom
dearchap merged 2 commits intourfave:mainfrom
Conversation
Previously, completions checked against all levels of subcommands. This change has it look only for top-level commands, which must necessarily be present before their children. It also adds hidden top-level commands to the list.
dearchap
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Three optimizations:
ensureHelp()has already seen to this.Which issue(s) this PR fixes:
None. I can make one if it helps. This is in preparation for #2120.
Special notes for your reviewer:
For full disclosure, I probably do not know enough about urfave/cli to say conclusively that there is no way you can "skip" a level such that a deeper sub-command could show up without being preceded by its parent?
Testing
Current main (53ad542) will give this result when
more-awesomehasHidden: truebefore 2. above is addressed.Release Notes
For less confusion, I'll save the bits about hidden command completion for the next PR.