Skip to content

docs: fix the link to the migration discussion from v2 to v3#2085

Merged
abitrolly merged 1 commit intomainfrom
fix-migration-discussion-v2-to-v3
Apr 1, 2025
Merged

docs: fix the link to the migration discussion from v2 to v3#2085
abitrolly merged 1 commit intomainfrom
fix-migration-discussion-v2-to-v3

Conversation

@suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Apr 1, 2025 •
edited
Loading

What type of PR is this?

(REQUIRED)

  • documentation

What this PR does / why we need it:

This pull request fixes the link to the GitHub Discussion where to discussion how to migrate v2 to v3.
Now the link points to #921 , but this was closed and this is an issue for the migration v1 to v2.
So I created a discussion for the migration v2 to v3.

Which issue(s) this PR fixes:

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)

@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review April 1, 2025 03:44
@suzuki-shunsuke suzuki-shunsuke requested a review from a team as a code owner April 1, 2025 03:44
@abitrolly abitrolly merged commit 7593378 into main Apr 1, 2025
13 checks passed
@abitrolly abitrolly deleted the fix-migration-discussion-v2-to-v3 branch April 1, 2025 06:14
@github-project-automation github-project-automation bot moved this to Done in main Apr 1, 2025
@abitrolly
Copy link
Contributor

abitrolly commented Apr 1, 2025

@suzuki-shunsuke nice catch!

@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Apr 1, 2025

Oh? CI failed?

https://github.com/urfave/cli/actions/runs/14188563023/job/39748211402

@abitrolly
Copy link
Contributor

abitrolly commented Apr 1, 2025 •
edited
Loading

Publish docs job failed https://github.com/urfave/cli/actions/runs/14188563023/job/39748211402

Not sure what is not right for the gfmrun job.

@abitrolly
Copy link
Contributor

abitrolly commented Apr 1, 2025

https://github.com/urfave/gfmrun page doesn't contain any usage lines, the explanation how it works with imports, and why the process fails.

@abitrolly
Copy link
Contributor

abitrolly commented Apr 1, 2025

Looks like the problem is in processing docs/v3/examples/arguments/advanced.md - it pulls v1 and v3.

time="2025-04-01T06:15:04Z" level=info msg=start i=1/1 lang=go line=15 source=docs/v3/examples/arguments/advanced.md
go: creating new go.mod: module gfmrun/example15
go: to add module requirements and sums:
	go mod tidy
go: finding module for package github.com/urfave/cli/v3
go: downloading github.com/urfave/cli v1.22.16
go: downloading github.com/urfave/cli/v3 v3.1.0
go: found github.com/urfave/cli/v3 in github.com/urfave/cli/v3 v3.1.0
# command-line-arguments
Error: ./example-L15.go:17:16: undefined: Argument
Error: ./example-L15.go:18:5: undefined: StringArg
Error: ./example-L15.go:24:5: undefined: IntArg
Error: ./example-L15.go:30:5: undefined: StringArg
Error: ./example-L15.go:36:5: undefined: FloatArg

@abitrolly
Copy link
Contributor

abitrolly commented Apr 1, 2025

https://github.com/urfave/cli/blob/main/docs/v3/examples/arguments/advanced.md?plain=1

@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Apr 1, 2025
Closed
@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Apr 1, 2025

I opened an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abitrolly abitrolly abitrolly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suzuki-shunsuke @abitrolly