You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there a plan to also add a .golanci.yml file? I find the default config that it uses somewhat lacking. I think at least some linters from the bugs preset category would be good to have, for example the makezero linter would've spotted the following: errors.go:45:10: append to slice errs with non-zero initialized length. https://golangci-lint.run/usage/linters/ has a table with linters and their presets.
Is there a plan to also add a .golanci.yml file? I find the default config that it uses somewhat lacking. I think at least some linters from the bugs preset category would be good to have, for example the makezero linter would've spotted the following: errors.go:45:10: append to slice errs with non-zero initialized length. https://golangci-lint.run/usage/linters/ has a table with linters and their presets.
Adding more linters will be a future iteration, as that will entail cleaning up those bugs as well as integrating them. I will look into adding the golangci.yml.
@avorima I've added the .golangci.yaml along with the misspell package. If anything else should be added we can make an issue for it along with the current output of running the additional linter. I also confirmed that this file is parsed by the github action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
adds an action for
golangci-lint runWhich issue(s) this PR fixes:
Fixes #1663
Testing
https://github.com/skelouse/cli/actions/runs/4361565058
Release Notes