Fix:(issue_1071) Add support for duplicated flag check#1638
Merged
dearchap merged 4 commits intourfave:mainfrom Jan 9, 2023
Merged
Fix:(issue_1071) Add support for duplicated flag check#1638dearchap merged 4 commits intourfave:mainfrom
dearchap merged 4 commits intourfave:mainfrom
Conversation
commit 4092431d53cec591309497b2ba680c07c947c695
Author: Naveen Gogineni <dear.chap@gmail.com>
Date: Mon Jan 9 07:51:46 2023 -0500
Fix tests
commit f60d3ef
Merge: 9be98f1 fa750ab
Author: dearchap <dear.chap@gmail.com>
Date: Sun Jan 8 22:05:52 2023 -0500
Merge pull request urfave#1636 from dearchap/issue_1071
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #1071
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
make test
go test
For some reason the PR tests were passing but go test was failing in my branch. make test didnt seem to be running the tests.
Release Notes
(REQUIRED)