Skip to content

use get_file_type to open _pyio file types#719

Merged
mmckerns merged 1 commit intomasterfrom
python3140b2
Jun 1, 2025
Merged

use get_file_type to open _pyio file types#719
mmckerns merged 1 commit intomasterfrom
python3140b2

Conversation

@mmckerns
Copy link
Member

@mmckerns mmckerns commented Jun 1, 2025

Summary

use dill._dill.get_file_type to open file types from _pyio, as using _pyio.open directly causes error from call of IOBase.__del__. Enables removal of some cleanup in test_selected.py

Checklist

Documentation and Tests

  • Added relevant tests that run with python tests/__main__.py, and pass.
  • Added relevant documentation that builds in sphinx without error.
  • Added new features that are documented with examples.
  • Artifacts produced with the main branch work as expected under this PR.

Release Management

  • Added "Fixes #NNN" in the PR body, referencing the issue (#NNN) it closes.
  • Added a comment to issue #NNN, linking back to this PR.
  • Added rationale for any breakage of backwards compatibility.
  • Requested a review.

@mmckerns mmckerns added this to the dill-0.4.1 milestone Jun 1, 2025
@mmckerns mmckerns merged commit 9586c68 into master Jun 1, 2025
4 checks passed
@mmckerns mmckerns deleted the python3140b2 branch June 1, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant