Skip to content

diff USE_NUMPY imports numpy.ma#676

Merged
mmckerns merged 1 commit intomasterfrom
numpy_ma
Sep 9, 2024
Merged

diff USE_NUMPY imports numpy.ma#676
mmckerns merged 1 commit intomasterfrom
numpy_ma

Conversation

@mmckerns
Copy link
Member

@mmckerns mmckerns commented Sep 9, 2024 •
edited
Loading

Summary

numpy >= 2.0.0 doesn't import numpy.ma upon import of numpy. As we need MaskedConstant, import numpy.ma. Fixes #667

Checklist

Documentation and Tests

  • Artifacts produced with the main branch work as expected under this PR.

Release Management

  • Added "Fixes #NNN" in the PR body, referencing the issue (#NNN) it closes.
  • Added a comment to issue #NNN, linking back to this PR.

@mmckerns mmckerns added the bugfix label Sep 9, 2024
@mmckerns mmckerns added this to the dill-0.3.9 milestone Sep 9, 2024
@mmckerns mmckerns merged commit b281426 into master Sep 9, 2024
@mmckerns mmckerns deleted the numpy_ma branch September 9, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

dill-0.3.9

Development

Successfully merging this pull request may close these issues.

NumPy 2.0.0 test regression: test_diff.py: RecursionError: maximum recursion depth exceeded

1 participant

@mmckerns