Skip to content

type check for Integral, bool by value#675

Merged
mmckerns merged 1 commit intomasterfrom
integral
Sep 9, 2024
Merged

type check for Integral, bool by value#675
mmckerns merged 1 commit intomasterfrom
integral

Conversation

@mmckerns
Copy link
Member

@mmckerns mmckerns commented Sep 9, 2024 •
edited
Loading

Summary

replace check for isinstance of int with Integral, and isinstance for bool with check for True and False

Checklist

Documentation and Tests

  • Added relevant tests that run with python tests/__main__.py, and pass.
  • Added relevant documentation that builds in sphinx without error.
  • Artifacts produced with the main branch work as expected under this PR.

Release Management

  • Added rationale for any breakage of backwards compatibility.

@mmckerns mmckerns added this to the dill-0.3.9 milestone Sep 9, 2024
@mmckerns mmckerns merged commit 9bf8ca7 into master Sep 9, 2024
@mmckerns mmckerns deleted the integral branch September 9, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

compatibility

Projects

None yet

Milestone

dill-0.3.9

Development

Successfully merging this pull request may close these issues.

1 participant

@mmckerns