You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The _is_builtin_module function of dill/_dill.py has the following check in line 1587
if not hasattr(module, "__file__"): return True
If the check is not passed, then os.path.realpath(module.__file__) is called later in that function (line 1591).
This causes dill to crash when a module has __file__ set to None. This PR fixes that check so that when module.__file__ is None, the module is recognized as not builtin.
@miguelinux314: Thanks for catching this. In theory, __file__ could be set to anything, right? So, to mitigate a TypeError, would it be better to either type-check (i.e. with type) or to catch a TypeError? If None is the most common case, then you could check that as you have now first...
Based on this, I don't think one can get the __file__ attribute to differ both from a valid path string and None without actively trying to break the code. That's why I checked only for None and left other cases to crash. However, if you feel the dill library would be sturdier considering the manual fiddling cases, my recommendation would be a try-catch of lines 1620 to 1629 with TypeError. I'd be happy with either solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
_is_builtin_modulefunction ofdill/_dill.pyhas the following check in line 1587if not hasattr(module, "__file__"): return TrueIf the check is not passed, then
os.path.realpath(module.__file__)is called later in that function (line 1591).This causes dill to crash when a module has
__file__set toNone. This PR fixes that check so that whenmodule.__file__ is None, the module is recognized as not builtin.Notes:
__file__is set it is a string, it will actually be none when importing a module without an__init__.pyfile in it.