Fix tox tests so they will actually fail#524
Conversation
|
It kinda looks like at some point, it was the job of the little bash script in |
|
Updated to clarify this applies to how |
|
@AdamWill: |
|
Yeah, I know it's a lot of work. Ironically, this is step six in a yak shave that started out with me cleaning up the infrastructure in one of my projects...:D |
mmckerns
left a comment
There was a problem hiding this comment.
You prefer the test results are all displayed at the end (i.e. flush=False)? Arguably it's a bit cleaner when there's other output -- however, other output really should not be there...
|
That wasn't intentional, honestly, I think I was basing off an older version of the existing file (I was jumping around between main and 0.3.5.1 a lot for packaging reasons). I do think it's maybe better, though. Two of the tests can produce output, I believe - |
|
I think the more appropriate thing is to leave it with |
As things stand, the tests never fail when run via tox. `__main__.py` runs each individual test script, but always exits 0, even if a test script exits >0. Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
Done. For the record, it was actually changed to use |
|
Thanks! It was due to be added after we dropped support for 2.7, but it didn't have it's own PR. |
|
@AdamWill, I really didn't make any comment on this change as it was very minor. The |
As things stand, the tests never fail when run via tox.
__main__.pyruns each individual test script, but always exits0, even if a test script exits >0.
Signed-off-by: Adam Williamson awilliam@redhat.com