Bring back old method pickling function#511
Merged
mmckerns merged 1 commit intouqfoundation:masterfrom Jun 16, 2022
Merged
Conversation
This is a very strange use case of functions and methods that Python's pickle package doesn't handle correctly (uqfoundation#510). This case used to work in pre-0.3.5 dill, so let's bring back the old dill implementation. The comments are irrelevant in Python 3.
|
Thanks for the rapid fix @anivegesana! Can confirm that this does completly fix my original issue too (boutproject/hypnotoad#122). |
mmckerns
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very strange use case of functions and methods that Python's pickle package doesn't handle correctly (#510). This case used to work in pre-0.3.5 dill, so let's bring back the old dill implementation.
The comments are irrelevant in Python 3.
Fixes #510