Create a soft_def shim to combine move_to and Getattr#473
Merged
mmckerns merged 2 commits intouqfoundation:masterfrom Jun 9, 2022
Merged
Create a soft_def shim to combine move_to and Getattr#473mmckerns merged 2 commits intouqfoundation:masterfrom
mmckerns merged 2 commits intouqfoundation:masterfrom
Conversation
mmckerns
approved these changes
Jun 7, 2022
Member
There was a problem hiding this comment.
This looks good, in general. I don't like the name soft_def. You aren't actually "defining" the shim, you kind of do that above when you write the function code... it's more like we register the shim in _dill. @anivegesana: What do you think of the name register, or something similar? Otherwise LGTM, and will pull when we agree on a name.
Contributor
Author
|
|
Member
|
How about: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New (hopefully more intuitive) construct to combine move_to and Getattr into one function call.
Resolves #447