Skip to content

Disable Next.js telemetry in compose by default#597

Merged
Dominastorm merged 1 commit intouptrain-ai:mainfrom
TensorTemplar:main
Mar 6, 2024
Merged

Disable Next.js telemetry in compose by default#597
Dominastorm merged 1 commit intouptrain-ai:mainfrom
TensorTemplar:main

Conversation

@TensorTemplar
Copy link
Copy Markdown
Contributor

Pull Request Template

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Description

Please include a summary of the change and which issue it addresses. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style (BLACK) of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • I have added an appropriate CHANGELOG entry.

Author's Note

This PR does not touch any code - it just disables the newly built-in Next.js telemetry in the docker-compose.yml by setting the env. I verified via bash run_uptrain.sh that telemetry is off.

The reasoning behind this change is to avoid unnecessary traffic and work for network or security teams.

Before:
Screenshot from 2024-03-06 16-28-07

After:
Screenshot from 2024-03-06 16-28-26

Copy link
Copy Markdown
Collaborator

@Dominastorm Dominastorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @TensorTemplar! Looks good to me!

@Dominastorm Dominastorm merged commit 4ac28d2 into uptrain-ai:main Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants