fix(gitlab): Panic when create merge request times out #7296
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeout increased to accomodate slow merge request creation on gitlab.com
Member
|
Thanks for the pull request, you don't need to create an issue if you already open a pull request |
olblak
approved these changes
Dec 24, 2025
Member
|
In the future we may need to parametrize this setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a Merge request on at least one of our repositories on gitlab.com seems to always take > 30 seconds. This caused a panic that is fixed by this PR. After fixing that I could troubleshoot it and couldn't find any obvious reason except gitlab.com sometimes being extremely slow when creating an MR.
To solve that issue I ended up bumping the timeout to 60 seconds which also seems to be the default timeout used by Gitlab itself. I'm also open to other solutions if anyone has any suggestions.
I've verified that, with these changes, the MR can be created against our repository.
I wasn't sure if I should also create an issue for this first, if needed I can still do that.
Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
Potential improvement