fix: autodiscovery container/helm auth #7238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds authentication support (username, password, and token) to autodiscovery plugins to fix authentication issues with Docker registries and Helm chart repositories. The changes enable users to provide registry credentials that will be passed through to generated manifests for authenticating with private registries.
Key changes:
- Added authentication fields (username, password, token) to manifest templates across all autodiscovery plugins
- Enhanced documentation with examples showing how to configure authentication
- Updated test cases to validate authentication credential propagation
Reviewed changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/plugins/autodiscovery/dockercompose/manifestTemplate.go | Added registry authentication fields to Docker Compose manifest templates |
| pkg/plugins/autodiscovery/dockercompose/main.go | Added authentication documentation and example to Spec |
| pkg/plugins/autodiscovery/dockercompose/compose.go | Extracted and propagated registry credentials from source specs |
| pkg/plugins/autodiscovery/dockercompose/main_test.go | Added test case validating token authentication for Docker registry |
| pkg/plugins/autodiscovery/dockerfile/manifestTemplate.go | Added registry authentication fields to Dockerfile manifest templates |
| pkg/plugins/autodiscovery/dockerfile/main.go | Added authentication documentation and example to Spec |
| pkg/plugins/autodiscovery/dockerfile/dockerfile.go | Extracted and propagated registry credentials from source specs |
| pkg/plugins/autodiscovery/nomad/manifestTemplate.go | Added registry authentication fields to Nomad manifest templates |
| pkg/plugins/autodiscovery/nomad/main.go | Added authentication documentation and example to Spec |
| pkg/plugins/autodiscovery/nomad/dockerDriver.go | Extracted and propagated registry credentials from source specs |
| pkg/plugins/autodiscovery/kubernetes/manifestTemplate.go | Added registry authentication fields to Kubernetes manifest templates |
| pkg/plugins/autodiscovery/kubernetes/main.go | Improved documentation formatting and added authentication documentation |
| pkg/plugins/autodiscovery/kubernetes/containers.go | Extracted and propagated registry credentials from source specs |
| pkg/plugins/autodiscovery/ko/manifestTemplate.go | Added registry authentication fields to Ko manifest templates |
| pkg/plugins/autodiscovery/ko/containers.go | Extracted and propagated registry credentials from source specs |
| pkg/plugins/autodiscovery/helm/main.go | Improved documentation formatting and added authentication documentation |
| pkg/plugins/autodiscovery/helm/containerManifest.go | Added registry authentication fields to Helm container manifest templates |
| pkg/plugins/autodiscovery/helm/container.go | Extracted and propagated registry credentials from source specs |
| pkg/plugins/autodiscovery/helm/dependencyManifest.go | Added token authentication field to Helm dependency manifest templates |
| pkg/plugins/autodiscovery/helm/dependencies.go | Added token extraction logic for Helm chart repository authentication |
| pkg/plugins/autodiscovery/helm/main_test.go | Added test case validating token authentication for Helm chart repository |
| pkg/plugins/autodiscovery/helmfile/manifestTemplate.go | Added token authentication field to Helmfile manifest templates |
| pkg/plugins/autodiscovery/helmfile/releases.go | Added token extraction logic for Helm chart repository authentication |
| pkg/plugins/autodiscovery/helmfile/main_test.go | Added test case validating token authentication for Helm chart repository |
| pkg/plugins/autodiscovery/flux/main.go | Improved documentation formatting for version filter |
| pkg/plugins/autodiscovery/flux/ociRepositoryManifestTemplate.go | Added registry authentication fields to Flux OCI repository manifest templates |
| pkg/plugins/autodiscovery/flux/ociRepositoryManifests.go | Extracted and propagated registry credentials from source specs |
| pkg/plugins/autodiscovery/flux/helmreleaseManifestTemplate.go | Added token authentication field to Flux Helm release manifest templates |
| pkg/plugins/autodiscovery/flux/helmreleaseManifests.go | Added token extraction logic for Helm chart repository authentication |
| pkg/plugins/autodiscovery/flux/main_test.go | Added test case validating token authentication for Helm chart repository |
| pkg/plugins/autodiscovery/fleet/manifestTemplate.go | Added token authentication field to Fleet manifest templates |
| pkg/plugins/autodiscovery/fleet/main.go | Added authentication documentation and auth struct for token support |
| pkg/plugins/autodiscovery/fleet/dependencies.go | Added token extraction logic for Helm chart repository authentication |
| pkg/plugins/autodiscovery/fleet/main_test.go | Added test case validating token authentication for Helm chart repository |
| pkg/plugins/autodiscovery/argocd/manifestTemplate.go | Added token authentication field to ArgoCD manifest templates |
| pkg/plugins/autodiscovery/argocd/main.go | Added authentication documentation and auth struct for token support |
| pkg/plugins/autodiscovery/argocd/application.go | Added token extraction logic for Helm chart repository authentication |
| pkg/plugins/autodiscovery/argocd/main_test.go | Added test case validating token authentication for Helm chart repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 38 out of 38 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Olblak <me@olblak.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 38 out of 38 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7030
Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
Potential improvement