Skip to content

refactor: gitlab client-go migration #7157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olblak merged 6 commits into from
Dec 12, 2025
Merged

refactor: gitlab client-go migration #7157

olblak merged 6 commits into from
Dec 12, 2025

Conversation

@chrxmvtik
Copy link
Contributor

@chrxmvtik chrxmvtik commented Dec 11, 2025

Fix #7156

Test

To test this pull request, you can run the following commands:

  1. Use automerge parameter on gitlab merge request action
  2. Configure gitlab repository to allow only merging when pipelines succeeded
  3. Pipeline automerges successfully

Additional Information

Checklist

  • I have updated the documentation via pull request in website repository.

What changed

  • Removed old http client
  • Implemented gitlab client-go client
  • Modified current functions that relied on previous client to utilize gitlab client-go
  • Types directly from client-go
  • Removed unused functions
  • Modified spec for gitlab merge request action - removed MergeWhenPipelineSucceeded (deprecated), kept just AutoMerge - for backward compatible clients merge_when_pipeline_succeeded api request is set as AutoMerge value.

@olblak olblak added the enhancement New feature or request label Dec 12, 2025
chrxmvtik
chrxmvtik commented Dec 12, 2025
View reviewed changes
chrxmvtik
chrxmvtik commented Dec 12, 2025
View reviewed changes
olblak
olblak previously approved these changes Dec 12, 2025
View reviewed changes
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pullrequest

@olblak olblak enabled auto-merge (squash) December 12, 2025 15:22
@olblak
Copy link
Member

olblak commented Dec 12, 2025

Hi @chrxmvtik,
Apparently the UT are not passing

cd pkg/plugins/resources/gitlab 
go test ./...

Would you have some time to look into this?

@chrxmvtik
Copy link
Contributor Author

chrxmvtik commented Dec 12, 2025

Hi @chrxmvtik, Apparently the UT are not passing

cd pkg/plugins/resources/gitlab 
go test ./...

Would you have some time to look into this?

Yes, of course, I will deep dive into it. Seems like it is not happy about Token being an empty string.

I will make sure all tests pass before pushing a new change.

auto-merge was automatically disabled December 12, 2025 16:13

Head branch was pushed to by a user without write access

@chrxmvtik
Copy link
Contributor Author

chrxmvtik commented Dec 12, 2025

@olblak tests are passing, now.

I was calling incorrect parameter to obtain project id, it is fixed now.

@olblak olblak enabled auto-merge (squash) December 12, 2025 16:58
@olblak
Copy link
Member

olblak commented Dec 12, 2025

Thank you very much, once merged, I trigger a release

@olblak olblak merged commit 513893b into updatecli:main Dec 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olblak olblak olblak left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gitlab api client not using retry mechanism

2 participants

@chrxmvtik @olblak