feat: add --pipeline-ids param #7121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new --pipeline-ids parameter to filter which pipelines execute based on a comma-separated list of pipeline IDs. This is particularly useful in projects with many pipelines, especially those generated by autodiscovery features.
Key Changes:
- Added
--pipeline-idsflag to multiple commands (apply, diff, show, manifest, compose) - Modified
config.New()to accept and filter pipelines based on pipeline ID list - Updated
engine.Optionsto includePipelineIDsfield with documentation
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/root.go | Added pipelineIds variable and parsing logic to split comma-separated IDs |
| cmd/apply.go | Added --pipeline-ids flag to apply command |
| cmd/diff.go | Added --pipeline-ids flag to diff command |
| cmd/show.go | Added --pipeline-ids flag to show command |
| cmd/manifest_show.go | Added --pipeline-ids flag to manifest show command |
| cmd/manifest_upgrade.go | Added --pipeline-ids flag to manifest upgrade command |
| cmd/compose_apply.go | Added --pipeline-ids flag to compose apply command |
| cmd/compose_diff.go | Added --pipeline-ids flag to compose diff command |
| cmd/compose_show.go | Added --pipeline-ids flag to compose show command |
| pkg/core/engine/options.go | Added PipelineIDs field with documentation comments |
| pkg/core/engine/configuration.go | Updated to pass PipelineIDs to config.New() and added nil check |
| pkg/core/config/main.go | Refactored to accept pipeline ID filters, filter configs, and improved error handling |
| pkg/core/config/main_test.go | Updated test to pass empty pipeline ID list to New() |
| pkg/core/pipeline/main_test.go | Updated test to pass empty pipeline ID list to New() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Olblak <me@olblak.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a project contains a lot of pipeline, it can be useful to trigger a subset of them.
Especially when those pipeline were generated by the autodiscovery feature
This pull request add a new parameter
--pipeline-ids <comma separated list of pipelineid>to limit the pipeline executed based on a list of pipeline IDs.Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
/
Potential improvement
/