Skip to content

fix(temurin) fail explicitly when specifying condition or target of kind 'temurin'#2916

Merged
olblak merged 4 commits intoupdatecli:mainfrom
dduportal:fix/temurin/condition-target-not-supported
Oct 28, 2024
Merged

fix(temurin) fail explicitly when specifying condition or target of kind 'temurin'#2916
olblak merged 4 commits intoupdatecli:mainfrom
dduportal:fix/temurin/condition-target-not-supported

Conversation

@dduportal
Copy link
Copy Markdown
Contributor

Fix #2839

This PR ensures that any run with a manifest using conditions or targets of type temurin are failing with an explicit message for the end user.

Running this PR with the manifest at https://github.com/gounthar/docker/blob/2353803ff5fad52db4b48429ddc394414f98bfa6/updatecli/updatecli.d/jdk21.yaml ends with the following message:

condition: condition#checkTemurinAlpineRelease
-----------------------------------

ERROR: something went wrong in "condition#checkTemurinAlpineRelease" : Condition not supported for the resources of kind 'temurin'

Pipeline "Bump JDK21 version" failed
Skipping due to:
        something went wrong during target execution

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/resources/temurin
go test

Additional Information

Potential improvement

In the future we could implement conditions of type temurin. See #2915

…ind 'temurin'

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal added bug Something isn't working target Related to updatecli target condition Modify condition resource temurin labels Oct 27, 2024
Comment thread pkg/plugins/resources/temurin/condition.go Outdated
Comment thread pkg/plugins/resources/temurin/target.go Outdated
Comment thread pkg/plugins/resources/temurin/condition.go Outdated
@olblak olblak enabled auto-merge (squash) October 28, 2024 09:02
@olblak olblak merged commit ee12728 into updatecli:main Oct 28, 2024
@dduportal dduportal deleted the fix/temurin/condition-target-not-supported branch October 28, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working condition Modify condition resource target Related to updatecli target temurin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Adoptium API has changed the location header

2 participants