fix(temurin) fail explicitly when specifying condition or target of kind 'temurin'#2916
Merged
olblak merged 4 commits intoupdatecli:mainfrom Oct 28, 2024
Conversation
…ind 'temurin' Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
1 task
olblak
reviewed
Oct 28, 2024
olblak
reviewed
Oct 28, 2024
olblak
reviewed
Oct 28, 2024
olblak
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2839
This PR ensures that any run with a manifest using conditions or targets of type
temurinare failing with an explicit message for the end user.Running this PR with the manifest at https://github.com/gounthar/docker/blob/2353803ff5fad52db4b48429ddc394414f98bfa6/updatecli/updatecli.d/jdk21.yaml ends with the following message:
Test
To test this pull request, you can run the following commands:
Additional Information
Potential improvement
In the future we could implement conditions of type temurin. See #2915