fix: show pipeline as skipped if all target are skipped#2849
Merged
olblak merged 9 commits intoupdatecli:mainfrom Oct 22, 2024
Merged
fix: show pipeline as skipped if all target are skipped#2849olblak merged 9 commits intoupdatecli:mainfrom
olblak merged 9 commits intoupdatecli:mainfrom
Conversation
Signed-off-by: Olblak <me@olblak.com>
loispostula
previously approved these changes
Oct 20, 2024
Member
Author
|
Thanks, @loispostula, for adding some tests on this area, It seems like I broke them :D |
Contributor
|
Tests are always good, but maybe the tests are broken |
Member
Author
|
In this case tests were good :) |
Signed-off-by: Olblak <me@olblak.com>
…o fix/pipelineskipped
Signed-off-by: Olblak <me@olblak.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest fix a regression introduced in #2800
Where a pipeline would be displayed as succeeded if all targets are skipped.
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement
We could apply the same logic if all conditions are skipped or all sources are skipped