Fix bug when gitea request fails#2806
Merged
olblak merged 1 commit intoupdatecli:mainfrom Oct 12, 2024
Merged
Conversation
Trying to print out the http status codes results in a deferencing null when they are not set. Thus crashing the cmd in case of an error. As we don't know the error, it's best to just print the error here.
1 task
Member
|
Thanks for the pullrequest, the go-scm library used in this project is a generic one that support different git provider but not all of them return error message via http request so it makes sense to ignore the request body in this case |
olblak
approved these changes
Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2802
Trying to print out the http status codes
results in a deferencing null when they are not
set. Thus crashing the cmd in case of an error.
As we don't know the error, it's best to just
print the error here.
Tradeoff
There may be cases in which the body is helpful to have, however that would need to be checked.
I think further down other cases handle HTTP codes so I don't think information is lost