Move to new PEP 517 standard with poetry and more "meta" package updates#270
Merged
upbit merged 8 commits intoupbit:masterfrom Sep 17, 2023
Merged
Move to new PEP 517 standard with poetry and more "meta" package updates#270upbit merged 8 commits intoupbit:masterfrom
upbit merged 8 commits intoupbit:masterfrom
Conversation
Switching to Poetry (the new defacto standard), compliant with PEP 517, for improved dependency handling, deterministic build process, and easier maintainability.
f190fec to
e5ebdd0
Compare
e5ebdd0 to
d71eeb1
Compare
nautics889
reviewed
Apr 26, 2023
nautics889
reviewed
Apr 26, 2023
nautics889
approved these changes
Apr 26, 2023
Contributor
nautics889
left a comment
There was a problem hiding this comment.
@Nachtalb
Anyway, checks are passed, also i've tested building project environment with Python 3.7.16 and 3.10.11, everything went well.
+1
Thank you!
11e7b7e to
b8150a0
Compare
nautics889
approved these changes
Apr 27, 2023
Contributor
nautics889
left a comment
There was a problem hiding this comment.
@Nachtalb
Great, thank you!
Owner
|
Thanks for the contribution! Sorry for late response, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates the project from using setuptools to Poetry, in line with PEP 517, to improve the project's overall development experience and maintainability. The key enhancements include:
With this migration, the project benefits from a more robust build process, ultimately contributing to higher code quality and a smoother development workflow.
In addition to poetry, I have also updated the remaining "meta" packages (mypy, black, pre-commit etc.):