Merged
Conversation
Add a deploy command that creates an exec and an endpoint for that exec.
noorvir
reviewed
Jul 13, 2023
cmd/deploy.go
Outdated
Comment on lines
+26
to
+29
| const errMsg = "❌ Invalid arguments. You must pass a file path to deploy.\n" + | ||
| "See `unweave deploy --help` for more information" | ||
| ui.Errorf(errMsg) | ||
| os.Exit(1) |
Contributor
There was a problem hiding this comment.
I'm guessing this is temporary? We shouldn't need this restriction once ready
Contributor
Author
There was a problem hiding this comment.
It's based on (my interpretation of) the spec, I can easily change it.
Would deploy without a filepath skip the copy?
Contributor
There was a problem hiding this comment.
Yeah I don't see a reason where the user must specify a file. Maybe the file is already present on the container image. If not, the build will fail and that's fine as long as we tell the user why.
noorvir
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a deploy command that creates an exec and an endpoint for that exec.