Allow creating an exec with cpu node types#31
Merged
Conversation
Update the ls-node-types command to list CPU node types. Update the session logging and listing to print the node type.
noorvir
reviewed
Jun 26, 2023
| regions = strings.Join(nodeType.Regions, ", ") | ||
| } | ||
| row := ui.Row{ | ||
| nodeType.Type, |
Contributor
There was a problem hiding this comment.
This printed table is getting pretty wide and doesn't fit on one screen. We might need to refactor it to only include minimal identifying info (name, status, type, createdAt (?), and leave the rest to the unweave ls <exec-name> command (which would then print the info vertically.
Default to the intel cpu node type, unless a --gpu-type is passed on the cli. The default is set in the .unweave/config.toml file.
noorvir
approved these changes
Jun 27, 2023
0f6cb99 to
ace7815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the ls-node-types command to list CPU node types. Update the session logging and listing to print the node type.
ls-node-types command has a
Typecolumn, CPU or GPU.The node types are also sorted by price.
Update the
exec,ssh, andnewcommands to accept a--cpu-type. This is mutually exclusive with--gpu-type.