Conversation
caldempsey
commented
Jun 1, 2023
# Conflicts: # cmd/ssh.go
noorvir
reviewed
Jun 1, 2023
noorvir
requested changes
Jun 1, 2023
| } else if input == "sess:" { | ||
| return "", fmt.Errorf("ExecId not specified") | ||
| } else { | ||
| return "", nil |
Contributor
There was a problem hiding this comment.
This is somewhat confusing. I'd expect this to return an error if the exec wasn't parsed. I see you can some conditional logic above for the case where you handle the empty string case.
If this works it's fine and we can refactor later. Just hard to follow the logic
Contributor
Author
There was a problem hiding this comment.
yeah i see what you mean, i'll try to think about a re-write of this in the next pass, but it works for the for loop
noorvir
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request (PR) adds the Copy command to the Unweave CLI. The approach is to reuse the existing CopySource function but modify it slightly to make it more versatile, which prevents a large diff.
Before merging, we may want to consider adding some quality-of-life (QoL) improvements such as:
Example flow: