Skip to content

[UNW-176] Ensure Root logs into the Source dir (SSH)#10

Merged
noorvir merged 3 commits intomasterfrom
callum/goto-unweave-dir
May 23, 2023
Merged

[UNW-176] Ensure Root logs into the Source dir (SSH)#10
noorvir merged 3 commits intomasterfrom
callum/goto-unweave-dir

Conversation

@caldempsey
Copy link
Copy Markdown
Contributor

@caldempsey caldempsey commented May 22, 2023

Unweave user's SSH using Root, after testing various methods the only way this seems to work is by appending the .bashrc file. The natural place to do this seems to be when copying source.

Tried both using the LocalCommand SSH config and RemoteCommand SSH config directives to no avail. Instead of looking around SSH found its simpler to do what I'd probably do if setting up on my home machine 😛

This PR adds support for logging in as root to where the source files were extracted by appending a 'cd' to the root .bashrc file.

Before Merge / Future Work

  • We need to run a quick test that this works with VSCode once related PRs are merged in, if not will have to investigate that as a separate issue. Currently master is broken so we can't run an E2E.

@caldempsey caldempsey requested a review from noorvir May 22, 2023 13:30
@caldempsey caldempsey changed the title Update .bashrc to ensure Root logs into the Source dir Ensure Root logs into the Source dir (SSH) May 22, 2023
@caldempsey caldempsey changed the title Ensure Root logs into the Source dir (SSH) [UNW-176] Ensure Root logs into the Source dir (SSH) May 22, 2023
@noorvir noorvir merged commit de5aff6 into master May 23, 2023
@noorvir noorvir deleted the callum/goto-unweave-dir branch May 23, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants