Now it works on a uv venv#336
Merged
Merged
Conversation
Member
|
Ok this is great thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first pull request, I know is not much but is honest work
GGUF AND LLAMA.cpp does not work inside a uv venv
Trying to test unslothai/unsloth#3215 I discovered that when inside a
uv venv, the automatic installation of GGUF and llama.cpp overflows into the global system pip envFrom what @rolandtannous said on unslothai/unsloth#3487 ,
python -m venv venvdoes not work, A conda env works as intendedMy fix will allow unsloth to work on a
uv venvwithout condaSimple as f****
This morning I was doing a lot of stuff to check if the interpreter was inside a venv, if uv was installed etc....
Basically I was trying to check if you were in a venv, in that case check if the venv was created with
uvcheckingpyvenv.cfgand in that case overridefinal_piponcheck_pipBut I figure out if on the
PIP_OPTIONSI change the order, will try to useuvbefore the rest, and in the case that it is installed but you are not in a uv venv it should be compatibleTests
Tested on uv venv and conda env on debian