fix: avoid blocking the event loop with time.sleep in async load_checkpoint#6135
Merged
wasimysaid merged 3 commits intoJun 11, 2026
Merged
Conversation
The export route's load_checkpoint waits for the training subprocess to exit by calling time.sleep(0.5) in a loop (up to 30s) inside an async function. time.sleep blocks the whole event loop, so every other request to the server stalls for that duration. Use await asyncio.sleep(0.5), matching the async pattern already used elsewhere in this file (asyncio.to_thread, await asyncio.sleep).
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the load_checkpoint function in studio/backend/routes/export.py to use await asyncio.sleep(0.5) instead of the blocking time.sleep(0.5) while waiting for a training subprocess to exit. This prevents blocking the event loop in an asynchronous context. There are no review comments, and I have no further feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
load_checkpointinstudio/backend/routes/export.pyis anasyncroute handler. While waiting for the training subprocess to free the GPU, it does:time.sleep()is a blocking call. Inside an async handler it blocks the entire event loop — so for up to 30 seconds, every other request the server is handling stalls (no concurrency, no health checks, nothing).Fix
Use
await asyncio.sleep(0.5), which yields to the loop while waiting. This matches the async patterns already used throughout this same file (await asyncio.to_thread(...), andawait asyncio.sleep(0.1)further down).asynciois already imported. Also dropped the redundant inlineimport time.No behavior change other than no longer freezing the loop.