Skip to content

[pkg] Update querystringify and other deps (closes #175)#176

Merged
lpinca merged 1 commit intounshiftio:masterfrom
niftylettuce:master
Apr 25, 2019
Merged

[pkg] Update querystringify and other deps (closes #175)#176
lpinca merged 1 commit intounshiftio:masterfrom
niftylettuce:master

Conversation

@niftylettuce
Copy link
Copy Markdown
Contributor

No description provided.

@lpinca
Copy link
Copy Markdown
Member

lpinca commented Apr 25, 2019

Is this really needed? All deps use caret ranges and the latest version in that range is used on install.
Dependencies and dev dependencies are regularly updated by Greenkeeper.

@niftylettuce
Copy link
Copy Markdown
Contributor Author

niftylettuce commented Apr 25, 2019

Per my comment in #175, I think this is 100% necessary. The main thing in doing this is that we'll publish a new version of url-parse, and can then do npm deprecate url-parse@"<X.X.X" "Please upgrade to vX.X.X+ as an uncaught exception bug in querystringify has been fixed"

@lpinca
Copy link
Copy Markdown
Member

lpinca commented Apr 25, 2019

Ok it makes sense for the querystringify dep.

@lpinca lpinca merged commit 96662a3 into unshiftio:master Apr 25, 2019
@lpinca
Copy link
Copy Markdown
Member

lpinca commented Apr 25, 2019

Thank you.

cc: @3rd-Eden as I can't publish on npm.

@niftylettuce
Copy link
Copy Markdown
Contributor Author

Thank you all so much for being so prompt and continuing to dedicate time to open source. 👏

@3rd-Eden
Copy link
Copy Markdown
Member

Published as 1.4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants