fix: add napi-postinstall dep for workaround npm's bug#66
Conversation
WalkthroughThe changes update the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant npm
participant PostinstallScript
participant napi-postinstall
User->>npm: Install package
npm->>PostinstallScript: Run "postinstall" script
PostinstallScript->>napi-postinstall: Execute "napi-postinstall unrs-resolver check"
napi-postinstall-->>PostinstallScript: Perform post-install checks
PostinstallScript-->>npm: Complete installation
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to d66dcea in 50 seconds. Click for details.
- Reviewed
63lines of code in2files - Skipped
1files when reviewing. - Skipped posting
7draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. npm/package.json:47
- Draft comment:
Ensure the 'postinstall' script and dependency 'napi-postinstall' correctly trigger native binding checks. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. package.json:13
- Draft comment:
Version bumps in devDependencies and packageManager update look good; verify compatibility with your build workflow. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. npm/package.json:14
- Draft comment:
Repository field now a string; confirm this is consistent with project conventions. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. npm/package.json:46
- Draft comment:
Funding field changed from an object to a string; ensure this aligns with npm guidelines and remains consistent. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. npm/package.json:47
- Draft comment:
Added postinstall script using napi-postinstall to work around the native binding issue; verify this resolves the ESLint error. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
6. package.json:19
- Draft comment:
Updated dev dependency versions; ensure these upgrades (e.g. @napi-rs/cli, @napi-rs/wasm-runtime, @types/node, emnapi) are backward compatible. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
7. package.json:26
- Draft comment:
Package manager version bumped to pnpm@10.8.1; ensure this version is available in your build environment. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_1YYRPyMcubCt0HNy
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
close #56
Important
Add
napi-postinstalldependency and update package metadata and dependencies to address npm bug.napi-postinstallas a dependency innpm/package.jsonto workaround an npm bug.@napi-rs/clito3.0.0-alpha.78,@napi-rs/wasm-runtimeto^0.2.9,@types/nodeto^22.14.1, andemnapito^1.4.3inpackage.json.postinstallscript innpm/package.jsonto runnapi-postinstall unrs-resolver check.description,homepage, andrepositoryfields innpm/package.json.This description was created by
for d66dcea. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit