Add 'history_delete' method to HistoryBackend#253
Merged
syzop merged 1 commit intounrealircd:unreal60_devfrom Jun 17, 2023
Merged
Add 'history_delete' method to HistoryBackend#253syzop merged 1 commit intounrealircd:unreal60_devfrom
syzop merged 1 commit intounrealircd:unreal60_devfrom
Conversation
This will allow modules to implement deletion of specific messages (unlike history_destroy, which removes the entire history of a channel)
Member
|
Sure, this sounds fine. I will merge it after UnrealIRCd 6.1.1 is released. |
Member
|
I've merged the API call, thanks. As for the module, maybe start with an unrealircd-contrib module first? Then others can play around with it easily as well just by running ./unrealircd module install third/nameofyourmodule. See https://www.unrealircd.org/docs/Rules_for_3rd_party_modules_in_unrealircd-contrib (nothing too scary) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow modules to implement deletion of specific messages (unlike history_destroy, which removes the entire history of a channel)
For example, I wrote a third-party module for IRCv3 draft/message-redaction: https://github.com/progval/unrealircd-contrib/blob/redact/files/redact.c
I'll happily submit this module to Unreal itself if you're interested, after the spec stabilizes a bit.
This function offers nothing in Unreal itself; but I can write a stub module that allows opers to delete messages just as a demo, if you want some sort of built-in demo of the feature.