fix: apply and rollback error handling

elibosley · elibosley · commit 01fe150fd17e · 2025-01-28T15:58:30.000-05:00
diff --git a/api/src/unraid-api/unraid-file-modifier/unraid-file-modifier.service.ts b/api/src/unraid-api/unraid-file-modifier/unraid-file-modifier.service.ts
@@ -32,12 +32,8 @@ export class UnraidFileModificationService implements OnModuleInit, OnModuleDest
         }
     }
     async onModuleDestroy() {
-        try {
-            this.logger.log('Rolling back all modifications...');
-            await this.rollbackAll();
-        } catch (err) {
-            this.logger.error(`Failed to roll back modifications: ${err}`);
-        }
+        this.logger.log('Rolling back all modifications...');
+        await this.rollbackAll();
     }
 
     /**
@@ -90,7 +86,6 @@ export class UnraidFileModificationService implements OnModuleInit, OnModuleDest
             } else {
                 this.logger.error(`Failed to apply modification: ${modification.id}: ${error}`);
             }
-            throw error;
         }
     }
 
@@ -120,6 +115,4 @@ export class UnraidFileModificationService implements OnModuleInit, OnModuleDest
             }
         }
     }
-
-
 }

Original file line number	Diff line number	Diff line change
`@@ -32,12 +32,8 @@ export class UnraidFileModificationService implements OnModuleInit, OnModuleDest`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`	`async onModuleDestroy() {`
`35`		`- try {`
`36`		`- this.logger.log('Rolling back all modifications...');`
`37`		`- await this.rollbackAll();`
`38`		`- } catch (err) {`
`39`		- this.logger.error(`Failed to roll back modifications: ${err}`);
`40`		`- }`
	`35`	`+ this.logger.log('Rolling back all modifications...');`
	`36`	`+ await this.rollbackAll();`
`41`	`37`	`}`
`42`	`38`
`43`	`39`	`/**`
`@@ -90,7 +86,6 @@ export class UnraidFileModificationService implements OnModuleInit, OnModuleDest`
`90`	`86`	`} else {`
`91`	`87`	this.logger.error(`Failed to apply modification: ${modification.id}: ${error}`);
`92`	`88`	`}`
`93`		`- throw error;`
`94`	`89`	`}`
`95`	`90`	`}`
`96`	`91`
`@@ -120,6 +115,4 @@ export class UnraidFileModificationService implements OnModuleInit, OnModuleDest`
`120`	`115`	`}`
`121`	`116`	`}`
`122`	`117`	`}`
`123`		`-`
`124`		`-`
`125`	`118`	`}`