Improve Readability of main + Emphasize E-STOP#12
Merged
Iris-TheRainbow merged 4 commits intounofficial-rev-port:mainfrom May 8, 2024
cmontigel:main
Merged
Improve Readability of main + Emphasize E-STOP#12Iris-TheRainbow merged 4 commits intounofficial-rev-port:mainfrom cmontigel:main
Iris-TheRainbow merged 4 commits intounofficial-rev-port:mainfrom
cmontigel:main
Conversation
j5155
requested changes
May 8, 2024
Member
j5155
left a comment
There was a problem hiding this comment.
Looks great overall and I appreciate how quickly you made a PR!
I just want a few tweaks to the text formatting.
| style = tkinter.ttk.Style() | ||
| style.configure("Red.Label", foreground="red") | ||
| style.configure("Green.Label", foreground="green") | ||
| style.configure("Quit.TButton", foreground='red', font=('TkDefaultFont', 16, 'bold')) |
Member
There was a problem hiding this comment.
I think the bold text and font size increase is too much here, just making it red would be fine. I found it a little bit distracting and out of place with the large text and bold.
| self.device_info_frame.grid(row=0) | ||
| self.device_info_frame.grid(sticky=(N, S, E, W)) | ||
|
|
||
| self.device_info_frame.config(height=100, width=100) |
Member
There was a problem hiding this comment.
Code formatting changes look fine to me.
Contributor
|
looks good. merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
__main__.pyfor readabilityE-STOPbutton red and bold to stand outAdditions:
Quit.TButtonin theApplicationclass of__main__.py, used byself.Quit_button