Merged
Conversation
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
antfu
previously requested changes
Mar 31, 2022
packages/core/src/generator/index.ts
Outdated
| return breakpoints | ||
| } | ||
|
|
||
| resolveVerticalBreakpoints() { |
Member
There was a problem hiding this comment.
Those two should belong to preset-mini instead of core. The core should be agnostic to how the theme object has been defined.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix the breakpoints from user config theme:
generator: add resolve breakpoints utilitiessrc/utils/utilitiesonpreset-minipreset-mini: size and breakpointspreset-wind: containercustom breakpointswith custom generator)@unocss/preset-typographyto roottsconfig.jsonThis PR doesn't solve the order problem, maybe we should document it or try to fix it later.
closes #778