fix(svelte-scoped): replace build hook with buildEnd to remove setAss…#5159
Merged
zyyv merged 1 commit intounocss:mainfrom Apr 7, 2026
Conversation
…etSource causing failed builds in vite 8
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
zyyv
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…etSource causing failed builds in vite 8
setAssetSourcewas removed (well, not implemented) in Rolldown which caused failed builds in Svelte-scoped when upgrading to Vite 8. It is unclear how willing they are to reimplement it since Vite 8 was released anyway, but in this case there was no real need for it in the first place.This PR moves everything into
buildEndso the on-demand theme functionality inpresetWind4continues working without problems.fixes #5158