feat(preset-wind4): enhance color systax & support color-interpolation-method parsed#4729
Merged
feat(preset-wind4): enhance color systax & support color-interpolation-method parsed#4729
color-interpolation-method parsed#4729Conversation
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
zyyv
commented
Jun 11, 2025
Comment on lines
+47
to
+49
| "text-[color:--variable]", | ||
| "text-[color:var(--color)]", | ||
| "text-[color:var(--color-x)]:[trick]", |
Member
Author
There was a problem hiding this comment.
Due to the use of getStringComponents to parse the separator, it is difficult to support the format of color:xxx.
Member
Author
There was a problem hiding this comment.
Suggested change
| "text-[color:--variable]", | |
| "text-[color:var(--color)]", | |
| "text-[color:var(--color-x)]:[trick]", | |
| "c-[--variable]", | |
| "c-[var(--color)]", | |
| "c-[var(--color-x)]:[trick]", |
I suggest you make the following changes before it is compatible.
Comment on lines
-136
to
+146
| const split = splitShorthand(body, 'color') | ||
| let split | ||
| const [front, ...rest] = getStringComponents(body, ['/', ':'], 3) ?? [] | ||
|
|
||
| if (front != null) { | ||
| const match = (front.match(bracketTypeRe) ?? [])[1] | ||
|
|
||
| if (match == null || match === 'color') { | ||
| split = [front, ...rest] | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Due to stricter parsing of delimiters using getStringComponents
This was referenced Jun 24, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4669, close #4673
This PR changes are as follows:
in srgbby default for theme colors, addsupportjudgment foroklab, and output them togetheroklabby default for non-theme colors