Skip to content

fix(vscode): when loadContextInDirectory error not add contextsMap#4135

Closed
Simon-He95 wants to merge 6 commits intounocss:mainfrom
Simon-He95:vscode-contextLoader
Closed

fix(vscode): when loadContextInDirectory error not add contextsMap#4135
Simon-He95 wants to merge 6 commits intounocss:mainfrom
Simon-He95:vscode-contextLoader

Conversation

@Simon-He95
Copy link
Copy Markdown
Member

close: #4133
If an error is reported, do not append it to this.contextsMap, otherwise it will be cached and subsequent updates will not take effect.
By the way, the @ method of unconfig using alias does not seem to be supported.

@Simon-He95 Simon-He95 requested a review from antfu as a code owner September 10, 2024 07:26
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 10, 2024

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 25634f2
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/66dff4a54c86580008bcec7f
😎 Deploy Preview https://deploy-preview-4135--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Sep 10, 2024

Open in Stackblitz

commit: d051732

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 10, 2024

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d051732
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/6718640e1cfe4000083ef9a9
😎 Deploy Preview https://deploy-preview-4135--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liangmiQwQ
Copy link
Copy Markdown
Contributor

liangmiQwQ commented Feb 24, 2026

Met the same issue, hope it can be merged soon ❤️ (/cc @zyyv)

(Can also replace this line with if (cached !== undefined && cached !== null) to fix)

@zyyv
Copy link
Copy Markdown
Member

zyyv commented Feb 25, 2026

I think #4133 is fine and shouldn't be fixed.
@liangmiQwQ If you have a new issue report, you can create a new pull request. Since VS Code extensions are inconvenient to test, please record relevant videos locally so I can review them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(extension): unocss vscode extension hangs when using tsconfig paths imports in config file

3 participants