feat(preset-mini)!: prioritize length instead of color#3353
Merged
antfu merged 7 commits intounocss:mainfrom Nov 30, 2023
Merged
feat(preset-mini)!: prioritize length instead of color#3353antfu merged 7 commits intounocss:mainfrom
antfu merged 7 commits intounocss:mainfrom
Conversation
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
I'll defer this to the next minor version to be sure. Before that, can you help resolving the conflicts? Thanks |
e2b4658 to
e513043
Compare
Member
|
Could you help resolving the conflicts? Thanks |
Member
Author
|
I'm on mobile. If the test isn't passing, I'll retry later |
ae37bfc to
606a429
Compare
antfu
approved these changes
Nov 30, 2023
zyyv
reviewed
Dec 24, 2023
Comment on lines
+417
to
+418
| .c-\$color-variable\/\$opacity-variable, | ||
| .c-\$color-variable\/10{color:var(--color-variable);} |
Member
There was a problem hiding this comment.
@chu121su12 , I find this is a bad css test case, miss $opacity-variable.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking only for those who import
textColorsseparately as a rule those who depends on usingtext-<color>overridingcolor-<x>.