fix(vscode): rootRegisterAuto broken#3337
Merged
antfu merged 2 commits intounocss:mainfrom Nov 15, 2023
Merged
Conversation
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
reviewed
Nov 15, 2023
packages/vscode/src/index.ts
Outdated
| const ctx = (Array.isArray(root) && root.length) | ||
| ? await rootRegisterManual(ext, root, projectPath, status) | ||
| : await rootRegisterAuto(ext, typeof root === 'string' ? root : projectPath, config, status) | ||
| : await rootRegisterAuto(ext, typeof root === 'string' ? root : projectPath, config, status, projectPath) |
Member
There was a problem hiding this comment.
Should we resolve root in the second argument directly?
Member
Author
|
I think |
1 task
This was referenced Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.