test: add test for esbuild/utils.ts#492
Merged
Conversation
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
commit: |
ysknsid25
commented
Apr 8, 2025
Contributor
Author
There was a problem hiding this comment.
filename is vitest.config.ts but import defineConfig from vite. so it Corrected.
and Coverage acquisition ranges were set for accurate measurements.
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
test/unit-tests/esbuild/utils.test.ts:118
- Using async on the describe block may cause unexpected behavior; consider moving the async keyword to the individual test (it block) instead.
describe('createBuildContext', async () => {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sxzz
approved these changes
Apr 9, 2025
This was referenced Apr 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #489 but to be continue...
before
after